Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

afvl command improvements #3945

Merged
merged 1 commit into from
Oct 31, 2023
Merged

afvl command improvements #3945

merged 1 commit into from
Oct 31, 2023

Conversation

imbillow
Copy link
Contributor

  • in SHORT mode only print @ COMPOSITE or @ LOCLIST and omit the details
  • in LONG and TABLE mode [(0x8010fb1c, 0x8010fb3f): a4, (0x8010fb42, 0x8010fb48): a13, (0x8010fb48, 0x8010fb5e): a4, (0x8010fb5e, 0x8010fb64): a13, (0x8010fb64, 0x8010fb6d): a4] => [(0x8010fb1c, 23): a4, (0x8010fb42, 6): a13, (0x8010fb48, 16): a4, (0x8010fb5e, 6): a13, (0x8010fb64, 9): a4]

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

closes #3943

@imbillow
afvl command improvements
7948424 
- in SHORT mode only print `@ COMPOSITE` or `@ LOCLIST` and omit the details
- in LONG and TABLE mode `[(0x8010fb1c, 0x8010fb3f): a4,	(0x8010fb42, 0x8010fb48): a13,	(0x8010fb48, 0x8010fb5e): a4,	(0x8010fb5e, 0x8010fb64): a13,	(0x8010fb64, 0x8010fb6d): a4]`
  => `[(0x8010fb1c, 23): a4,	(0x8010fb42, 6): a13,	(0x8010fb48, 16): a4,	(0x8010fb5e, 6): a13,	(0x8010fb64, 9): a4]`
@imbillow imbillow linked an issue Oct 31, 2023 that may be closed by this pull request
afvl command improvements #3943
Closed
XVilka
XVilka approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the new output is a bit shorter and also allows to discern between composite and loclist storage information even in the pdf output. Thanks!

@XVilka XVilka merged commit fde0358 into dev Oct 31, 2023
45 of 47 checks passed
@XVilka XVilka deleted the 3943-afvl-command-improvements branch October 31, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

Assignees
No one assigned
Labels
API rz-test RzAnalysis RzBin RzCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

afvl command improvements
2 participants
@imbillow @XVilka