Fix old math commands #3828
Merged
Fix old math commands #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ret2libc
requested review from
XVilka,
wargio,
thestr4ng3r and
kazarmy
as code owners
github-actions
bot
added
documentation
XVilka
requested changes
Sep 4, 2023
There was a problem hiding this comment.
Many broken tests, likely related to the offset changes:
[XX] db/cmd/cmd_pd_bytes pD -10
RZ_NOPLUGINS=1 /private/var/folders/bc/yvvw2g2s4jlg9r8x7tf61xv800009d/T/woodpecker-local-1287038090/rizinorg/rizin/prefix/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -eflirt.sigdb.load.home=false -N -Qc 'e asm.arch=x86
e asm.bits=64
e asm.bytes=true
wx 90909090909090909090 ; s 10 ; pD -10
' malloc://1024
-- stdout
--- expected
+++ actual
@@ -1,10 +1,10 @@
- 0x00000000 90 nop
- 0x00000001 90 nop
- 0x00000002 90 nop
- 0x00000003 90 nop
- 0x00000004 90 nop
- 0x00000005 90 nop
- 0x00000006 90 nop
- 0x00000007 90 nop
- 0x00000008 90 nop
- 0x00000009 90 nop
+ 0x0000000a 90 nop
+ 0x0000000b 90 nop
+ 0x0000000c 90 nop
+ 0x0000000d 90 nop
+ 0x0000000e 90 nop
+ 0x0000000f 90 nop
+ 0x00000010 90 nop
+ 0x00000011 90 nop
+ 0x00000012 90 nop
+ 0x00000013 90 nop
[**] db/cmd/cmd_fuzzed 16173 OK 1011 BR 12 XX 34 FX
[XX] db/cmd/cmd_pd_bytes pD -10 @ 0
RZ_NOPLUGINS=1 /private/var/folders/bc/yvvw2g2s4jlg9r8x7tf61xv800009d/T/woodpecker-local-1287038090/rizinorg/rizin/prefix/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -eflirt.sigdb.load.home=false -N -Qc 'e asm.arch=x86
e asm.bits=64
e asm.bytes=true
e analysis.hasnext=0
wx b8010000004839ca7f00
pD -10 @ 10
' malloc://512
-- stdout
--- expected
+++ actual
@@ -1,3 +1,3 @@
- 0x00000000 b801000000 mov eax, 1
- 0x00000005 4839ca cmp rdx, rcx
- ,=< 0x00000008 7f00 jg 0xa
+ 0x0000000a b801000000 mov eax, 1
+ 0x0000000f 4839ca cmp rdx, rcx
+ ,=< 0x00000012 7f00 jg 0x14
[XX] db/cmd/cmd_pd_bytes pD -10 @ 10
RZ_NOPLUGINS=1 /private/var/folders/bc/yvvw2g2s4jlg9r8x7tf61xv800009d/T/woodpecker-local-1287038090/rizinorg/rizin/prefix/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -eflirt.sigdb.load.home=false -N -Qc 'e asm.arch=x86
e asm.bits=64
e asm.bytes=true
e analysis.hasnext=0
wx b8010000004839ca7f00
pD -10 @ 0xa
' malloc://512
-- stdout
--- expected
+++ actual
@@ -1,3 +1,3 @@
- 0x00000000 b801000000 mov eax, 1
- 0x00000005 4839ca cmp rdx, rcx
- ,=< 0x00000008 7f00 jg 0xa
+ 0x0000000a b801000000 mov eax, 1
+ 0x0000000f 4839ca cmp rdx, rcx
+ ,=< 0x00000012 7f00 jg 0x14
ret2libc
commented
Sep 4, 2023
We have moved the `?x` commands to `%x`, thus now no command should start with `?`. This patch makes the parser fail to parse `?x` strings.
ret2libc
force-pushed
the
fix-old-math-commands
branch
from
32d3159
to
fc296fa
Compare
XVilka
requested changes
Sep 13, 2023
XVilka
pushed a commit
that referenced
this pull request
Sep 14, 2023
* core/cmd: Adjust math commands * shell: make `?x` commands a parsing failure We have moved the `?x` commands to `%x`, thus now no command should start with `?`. This patch makes the parser fail to parse `?x` strings. * core/tui: use APIs in panels * There's no `%q` anymore, use `%=`
XVilka
pushed a commit
that referenced
this pull request
Sep 14, 2023
* core/cmd: Adjust math commands * shell: make `?x` commands a parsing failure We have moved the `?x` commands to `%x`, thus now no command should start with `?`. This patch makes the parser fail to parse `?x` strings. * core/tui: use APIs in panels * There's no `%q` anymore, use `%=`
vlasel
pushed a commit
to vlasel/rizinorg-rizin
that referenced
this pull request
Sep 16, 2023
* core/cmd: Adjust math commands * shell: make `?x` commands a parsing failure We have moved the `?x` commands to `%x`, thus now no command should start with `?`. This patch makes the parser fail to parse `?x` strings. * core/tui: use APIs in panels * There's no `%q` anymore, use `%=`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
There were still many references to
?commands, which are now%.Test plan
...
Closing issues
...