Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incomplete ESIL support for WASM #3497

Merged
merged 1 commit into from
May 4, 2023
Merged

Remove incomplete ESIL support for WASM #3497

merged 1 commit into from
May 4, 2023

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented May 4, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Since the ESIL support was too basic, incomplete and useless in this state, just removing it completely, to make the ESIL->RzIL migration easier: #2080

Test plan

CI is green

@XVilka XVilka requested review from wargio and ret2libc May 4, 2023 05:43
@XVilka XVilka requested a review from thestr4ng3r as a code owner May 4, 2023 05:43
@XVilka XVilka mentioned this pull request May 4, 2023
Open
38 tasks
@XVilka XVilka requested a review from kazarmy as a code owner May 4, 2023 06:50
@XVilka XVilka merged commit c7c42af into dev May 4, 2023
@XVilka XVilka deleted the remove-wasm-esil branch May 4, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ret2libc ret2libc ret2libc approved these changes

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

Assignees
No one assigned
Labels
rz-test RzAnalysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XVilka @ret2libc