Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD x86_64 debug tests #3273

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add FreeBSD x86_64 debug tests #3273

wants to merge 2 commits into from

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Jan 8, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Adds basic FreeBSD x86_64 debug tests.

Requires rizinorg/rizin-testbins#101

Test plan

FreeBSD CI is green

Closing issues

Partially addresses #3072

@XVilka
Copy link
Member Author

XVilka commented Nov 1, 2023

@arrowd, you might be interested in this one, by the way. Feel free to send a new PR if you want.

@XVilka XVilka modified the milestones: 0.7.0, 0.8.0 Dec 8, 2023
@XVilka
Copy link
Member Author

XVilka commented Jun 1, 2024

@kazarmy as you can see, even FreeBSD debugging doesn't work:

[XX] db/archos/freebsd-x64/dbg write gpr
RZ_NOPLUGINS=1 /home/build/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -eflirt.sigdb.load.home=false -N -d -qc 'db @ main + 64
dc
dr rax
dr rax = 1337
dc
' bins/elf/calculate-freebsd-x64
-- stdout
--- expected
+++ actual
@@ -1,2 +1,2 @@
-rax = 0x000000000000002a
-Result = 1337
+Result = 42
+Debugging is not enabled. Run ood?

-- stderr
--- expected
+++ actual
@@ -1,4 +1,27 @@
-hit breakpoint at: f70
+Process 
+with 
+PID 
+387 
+child 
+exited 
+with 
+status 
+Process 
+finished
 
-Process finished
 
+ERROR: 
+Failed 
+to 
+read 
+ERROR: 
+No 
+such 
+register 
+or 
+register 
+type: 
+ERROR: 
+Failed 
+to 

https://builds.sr.ht/~thestr4ng3r/job/1239045

@kazarmy
Copy link
Member

kazarmy commented Jun 1, 2024

Well that's one reason why no testing was done in #4524 - debugging might have been broken well before the build itself broke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants