Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RZ_API functions out of the command handlers code #3013

Merged
merged 4 commits into from
Sep 7, 2022

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Sep 7, 2022

DO NOT SQUASH

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

RZ_API functions have no place in the librz/core/cmd/*.c or librz/core/tui/*.c files (librz/core/cmd/cmd_api.c is an exception since it provides the API to work with commands themselves).

Thus, I moved some of the functions into better places, documenting when necessary. This is purely a code movement PR.
I didn't document ESIL functions since they are planned to be removed sometime in the future anyway.

Can be reviewed per commit.

Test plan

CI is greeen

@XVilka XVilka added the refactor Refactoring requests label Sep 7, 2022
@XVilka XVilka merged commit bdc0530 into dev Sep 7, 2022
@XVilka XVilka deleted the asan-core-refactoring branch September 7, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API refactor Refactoring requests RzCore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant