-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ag
to rzshell
#2916
Convert ag
to rzshell
#2916
Conversation
37536f7
to
f4d9a88
Compare
b2b7a11
to
09a4616
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imbillow please rebase on top of the latest |
@imbillow, why did you remove some tests? |
Because the processing of |
@imbillow then please mark them "BROKEN=1" instead of removing and open an issue so they aren't forgotten. |
This reverts commit 45487b6.
OK |
@ret2libc please take a look again and let's merge this if you don't have any big objections. Further graph improvements can be done in separate PRs. |
Your checklist for this pull request
Detailed description
Before many ag commands had a "format" as a part of the command itself, e.g. agfk - here command was agf while k is the format. For the time being it will become agf k, unless you have better ideas.
ag<graphtype><format>
->ag<graphtype> <format>
but
ag<graphtype>w
->agw <graphtype>
Maybe open another PR to do more refactoring and export some APIs
But this PR mainly focuses on convert to rzshell
Test plan
CI is green
Closing issues
Partially addresses #1442
previous PR #2757