-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v850 support for getting main offset #2380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a testcase.
Can you also add a test? (open a PR on rizin bin repo if needed) |
Explanation for changing I ran |
i think we need to test this on a bin without symbols. |
Sorry for the late response. Since this pr is not thoroughly tested, I will refine and reopen this in June (after some of my deadlines) if nobody solves it. |
@PeiweiHu could you please reopen/finish this one again? It would help the ongoing V850 RzIL conversion: #4103 For creating testcases these toolchains could be used:
cc @imbillow |
Ok, I will try to finish this when I am free. cc @XVilka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
3a87584
to
8d4cb50
Compare
8d4cb50
to
3dd5346
Compare
Your checklist for this pull request
Detailed description
Fix #2316. This pr adds support for v850 while getting main offset.
...
Test plan
If possible, I hope more v850 samples can be provided for the test (I searched but found only a few).
...
Closing issues
...