Convert as commands to the rzshell
#2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
XVilka
force-pushed
the
asan-as-rzshell
branch
from
4ff6d4d
to
97968b6
Compare
I think it's oki to accept just a string and recognize the type of argument, whether number or string. |
ret2libc
reviewed
Feb 14, 2022
XVilka
force-pushed
the
asan-as-rzshell
branch
from
97968b6
to
e5797fa
Compare
XVilka
force-pushed
the
asan-as-rzshell
branch
from
e5797fa
to
af35799
Compare
XVilka
changed the title
as commands to the rzshellas commands to the rzshell
ret2libc
reviewed
Feb 15, 2022
XVilka
force-pushed
the
asan-as-rzshell
branch
from
af35799
to
d5fb171
Compare
ret2libc
reviewed
Feb 15, 2022
XVilka
force-pushed
the
asan-as-rzshell
branch
3 times, most recently
from
ece2ba0
to
e0df62f
Compare
ret2libc
reviewed
May 3, 2022
ret2libc
approved these changes
May 3, 2022
wingdeans
pushed a commit
to wingdeans/rizin
that referenced
this pull request
May 13, 2022
wingdeans
pushed a commit
to wingdeans/rizin
that referenced
this pull request
May 13, 2022
nyoxi
added a commit
to nyoxi/rizin-book
that referenced
this pull request
Oct 30, 2023
PR #2323 [1] removed `ask` command and `asl` does not accept an argument any more. Instead there are two new commands `asn` and `asr` to query for number or name respectively. [1] rizinorg/rizin#2323 Signed-off-by: Tomáš Golembiovský <[email protected]>
wargio
pushed a commit
to rizinorg/book
that referenced
this pull request
Oct 31, 2023
PR #2323 [1] removed `ask` command and `asl` does not accept an argument any more. Instead there are two new commands `asn` and `asr` to query for number or name respectively. [1] rizinorg/rizin#2323 Signed-off-by: Tomáš Golembiovský <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
asjnow becameasljaskwas removedas <name>becameasn <name>as,asca,asctake now only the number as the argumentI have a question though - should I ignore the name argument in
ascaandasccompletely, or return it back and allow the argument to be either syscall number or syscall name?Test plan
CI is green
Closing issues
Partially addresses #1442