Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search RzAnalysisOp.analysis_vals[] for xrefs. #2067

Merged
merged 9 commits into from
Jan 4, 2022

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Dec 4, 2021

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

The function rz_core_analysis_search_xrefs does not search through the RzAnalysisOp.anlysis_vals[] array, which was added in #1614.

In this PR a simple loop is added which searches each value for references.

Test plan

Test case was added: The memw(R17+#0x0) = ##0x1c instruction has the 0x1c value stored in RzAnalysisOp.analysis_vals[0].

Closing issues

None

librz/core/canalysis.c Outdated Show resolved Hide resolved
librz/core/canalysis.c Show resolved Hide resolved
@XVilka XVilka changed the title Search RzAnalysisOp.anlysis_vals[] for xrefs. Search RzAnalysisOp.analysis_vals[] for xrefs. Dec 8, 2021
@XVilka XVilka added this to the 0.4.0 milestone Dec 27, 2021
@Rot127 Rot127 requested a review from XVilka January 3, 2022 08:57
@XVilka XVilka merged commit 63a3fbd into rizinorg:dev Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants