[TO BE REVERTED] bin.c: Double-free

rizinorg · May 2, 2024 · f0378a8 · f0378a8
1 parent ba780a7
commit f0378a8
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/librz/bin/bin.c b/librz/bin/bin.c
@@ -203,13 +203,8 @@ RZ_API void rz_bin_reloc_free(RZ_NULLABLE RzBinReloc *reloc) {
 	if (!reloc) {
 		return;
 	}
-	/**
-	 * TODO: leak in bin_elf, but it will cause double free in bin_pe if free here,
-	 * Because in the bin_elf implementation RzBinObject->imports and RzBinObject->relocs->imports
-	 * are two pieces of data, but they are linked to each other in bin_pe
-	 */
-	//	rz_bin_import_free(reloc->import);
-	//	rz_bin_symbol_free(reloc->symbol);
+	rz_bin_import_free(reloc->import);
+	rz_bin_symbol_free(reloc->symbol);
 	free(reloc);
 }