Skip to content

Commit

Permalink
Remove warning about missing calling convention (#3846)
Browse files Browse the repository at this point in the history
This warning turned out to be more misleading and spammy than actually
useful. For example, it speaks of a "file" when loading just a malloc,
and many architectures simply do not have any standardized calling
conventions, like 6502 or gb, in which case the analysis is fine without
any loaded cc info.
  • Loading branch information
thestr4ng3r authored Sep 12, 2023
1 parent 4dd4dcb commit a80f491
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions librz/core/cfile.c
Original file line number Diff line number Diff line change
Expand Up @@ -731,11 +731,7 @@ static bool core_file_do_load_for_io_plugin(RzCore *r, ut64 baseaddr, ut64 loada
if (cf) {
rz_pvector_push(&cf->binfiles, binfile);
}
if (rz_core_bin_apply_all_info(r, binfile)) {
if (!r->analysis->sdb_cc->path) {
RZ_LOG_WARN("No calling convention defined for this file, analysis may be inaccurate.\n");
}
}
rz_core_bin_apply_all_info(r, binfile);
plugin = rz_bin_file_cur_plugin(binfile);
if (plugin && !strcmp(plugin->name, "any")) {
RzBinObject *obj = rz_bin_cur_object(r->bin);
Expand Down

0 comments on commit a80f491

Please sign in to comment.