Fix missed sort op

rizinorg · May 12, 2024 · a46d6cc · a46d6cc
1 parent 9f4d76b
commit a46d6cc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/librz/core/cmd/cmd_eval.c b/librz/core/cmd/cmd_eval.c
@@ -91,6 +91,10 @@ RZ_API char *rz_core_theme_get(RzCore *core) {
 	return core->curtheme;
 }
 
+static int compare_strings(const char *s1, const char *s2, RZ_UNUSED void *user) {
+	return strcmp(s1, s2);
+}
+
 /**
  * \brief      Returns the list of the rizin themes.
  *
@@ -128,7 +132,8 @@ RZ_API RZ_OWN RzPVector /*<char *>*/ *rz_core_theme_list(RZ_NONNULL RzCore *core
 		set_s_free(themes);
 		return NULL;
 	}
-	rz_pvector_push_front(vec, strdup("default"));
+	rz_pvector_push(vec, strdup("default"));
+	rz_pvector_sort(vec, (RzPVectorComparator)compare_strings, NULL);
 	set_s_free(themes);
 	return vec;
 }

diff --git a/librz/core/tui/panels.c b/librz/core/tui/panels.c
@@ -6162,7 +6162,6 @@ RZ_IPI bool rz_core_visual_panels_root(RzCore *core, RzPanelsRoot *panels_root)
 		panels_root->cur_tab = 0;
 		__set_root_state(core, DEFAULT);
 		panels_root->theme_list = rz_core_theme_list(core);
-		rz_pvector_sort(panels_root->theme_list, cmpstr, NULL);
 		__init_new_panels_root(core);
 	} else {
 		if (rz_pvector_len(&panels_root->tabs) == 0) {