Fix mdmp UAF by leaking imports; use alt fix for pe

rizinorg · May 16, 2024 · 409bb2f · 409bb2f
1 parent cfe1707
commit 409bb2f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/librz/bin/bobj.c b/librz/bin/bobj.c
@@ -129,7 +129,7 @@ RZ_API RzBinRelocStorage *rz_bin_reloc_storage_new(RZ_OWN RzPVector /*<RzBinRelo
 		if (!strcmp(plugin->name, "coff")) {
 			ret->imp_shared = true;
 			ret->sym_shared = true;
-		} else if (rz_str_cmp_list("mach0 mach064", plugin->name, ' ')) {
+		} else if (rz_str_cmp_list("mach0 mach064 mdmp pe", plugin->name, ' ')) {
 			ret->imp_shared = true;
 		}
 	}

diff --git a/librz/bin/p/bin_pe.inc b/librz/bin/p/bin_pe.inc
@@ -431,8 +431,7 @@ static RzPVector /*<RzBinImport *>*/ *imports(RzBinFile *bf) {
 	if (!bf || !bf->o || !bf->o->bin_obj) {
 		return NULL;
 	}
-	// rz_bin core will free imports
-	RzPVector *ret = rz_pvector_new(NULL);
+	RzPVector *ret = rz_pvector_new((RzListFree)rz_bin_import_free);
 	if (!ret) {
 		return NULL;
 	}