ELF: skip visited segments in compute_symbols_from_segment()

rizinorg · Mar 31, 2024 · 110c2db · 110c2db
1 parent 9a27c4f
commit 110c2db
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/librz/bin/format/elf/elf_symbols.c b/librz/bin/format/elf/elf_symbols.c
@@ -253,18 +253,17 @@ static void elf_symbol_fini(void *e, RZ_UNUSED void *user) {
 }
 
 static bool compute_symbols_from_segment(ELFOBJ *bin, RzVector /*<RzBinElfSymbol>*/ *result, struct symbols_segment *segment, RzBinElfSymbolFilter filter, HtUU *set) {
-	ut64 offset = segment->offset + segment->entry_size;
+	if (has_already_been_processed(bin, segment->offset, set)) {
+		return true;
+	}
 
-	for (size_t i = 1; i < segment->number; i++) {
-		if (has_already_been_processed(bin, offset, set)) {
-			offset += segment->entry_size;
-			continue;
-		}
+	if (!ht_uu_insert(set, segment->offset, 1ULL)) {
+		return false;
+	}
 
-		if (!ht_uu_insert(set, offset, offset)) {
-			return false;
-		}
+	ut64 offset = segment->offset + segment->entry_size;
 
+	for (size_t i = 1; i < segment->number; i++) {
 		Elf_(Sym) entry;
 		if (!get_symbol_entry(bin, offset, &entry)) {
 			return false;