Add note regarding rz_bin_reloc_free and bin_coff (#4488)

rizinorg · May 12, 2024 · 0a05e42 · 0a05e42
1 parent 524119c
commit 0a05e42
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/librz/bin/bin.c b/librz/bin/bin.c
@@ -207,6 +207,9 @@ RZ_API void rz_bin_reloc_free(RZ_NULLABLE RzBinReloc *reloc) {
 	 * TODO: leak in bin_elf, but it will cause double free in bin_pe if free here,
 	 * Because in the bin_elf implementation RzBinObject->imports and RzBinObject->relocs->imports
 	 * are two pieces of data, but they are linked to each other in bin_pe
+	 * TODO: also, double free in bin_coff if free here,
+	 * Because in the bin_coff implementation imports and symbols are shared
+	 * between relocs
 	 */
 	//	rz_bin_import_free(reloc->import);
 	//	rz_bin_symbol_free(reloc->symbol);