Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Copy instruction bytes' to disassembly context menu #3242

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

frmdstryr
Copy link
Contributor

Your checklist for this pull request

Detailed description

This adds a "Copy instruction bytes" to the disassembly widget's context menu. Mainly as a shortcut to search for uses of an instruction (in my case use of an IO port).

image

Test plan (required)

Right click on an instruction and copy the bytes. Check that the asm matches.

Closing issues

@XVilka
Copy link
Member

XVilka commented Sep 4, 2023

@frmdstryr by the way, I noticed you work also on ESIL support in your plugin. I don't recommend spending time on this since we are sunsetting ESIL in favor of RzIL:

@frmdstryr
Copy link
Contributor Author

Ok, I will start looking at moving to that, thank you.

@XVilka XVilka merged commit 1e1c93d into rizinorg:dev Sep 6, 2023
9 checks passed
@XVilka
Copy link
Member

XVilka commented Sep 18, 2023

@frmdstryr I added an issue to track the C166 support. PRs to the mainstream are welcome since it's relatively popular architecture in the past: rizinorg/ideas#53

@frmdstryr frmdstryr deleted the copy-instruction-bytes branch September 18, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants