Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows heap widget #2723

Draft
wants to merge 15 commits into
base: dev
Choose a base branch
from
Draft

Windows heap widget #2723

wants to merge 15 commits into from

Conversation

MalhotraPulak
Copy link
Member

@MalhotraPulak MalhotraPulak commented Jul 29, 2021

Your checklist for this pull request

Detailed description

Initial implementation of windows heap widget

Shows the heap blocks in a table

Use Rizin from: rizinorg/rizin#1386

NOTE TYPES DO NOT WORK IN THIS PR
they were overhauled in new builds of rizin i will try to fix it once windows part is done

Test plan (required)

Closing issues

@yossizap yossizap self-requested a review August 1, 2021 06:52
@XVilka XVilka added this to the 2.0.3 milestone Aug 5, 2021
return this->values.size();
}

void HeapInfoModel::reload()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going through this freezes Cutter, the call to getWindowsHeaps should be done in an AsyncTask similar to Strings/FunctionsWidget.
Also worth trying to optimize rizin's side, listing an empty heap should take 20s+.

@XVilka
Copy link
Member

XVilka commented Aug 25, 2021

@PulakIIIT @yossizap @ITAYC0HEN @xarkes what is the status of this?

@yossizap
Copy link
Member

There are still major performance issues on rizin's side that should be fixed before merging.

@MalhotraPulak
Copy link
Member Author

@XVilka Need some performance improvements from Rizin side as heap parsing is very slow which causes cutter to hang up. I tried making the Rizin call async but encountered some crashes. At the moment I am busy with some real life stuff, planning to come back to this in a few weeks

@XVilka
Copy link
Member

XVilka commented Sep 13, 2021

@PulakIIIT some types fixes were pushed to the latest master, please rebase your PR and resolve the conflicts.

@XVilka XVilka removed this from the 2.0.3 milestone Sep 16, 2021
@XVilka XVilka added this to the 2.0.4 milestone Sep 25, 2021
@ITAYC0HEN
Copy link
Member

@PulakIIIT what are the current obstacles you are facing? :)

@thestr4ng3r thestr4ng3r changed the base branch from master to dev December 21, 2021 12:42
@XVilka XVilka removed this from the 2.0.5 milestone Dec 26, 2021
@XVilka XVilka added this to the 2.0.6 milestone Dec 26, 2021
@XVilka
Copy link
Member

XVilka commented Mar 31, 2022

Moving to the next milestone.

@XVilka XVilka modified the milestones: 2.0.6, 2.0.7 Mar 31, 2022
@XVilka
Copy link
Member

XVilka commented Aug 17, 2022

@PulakIIIT, a lot has changed since, please resolve the conflicts and rebase against the latest dev. Also, it would be nice to finish it.

@XVilka
Copy link
Member

XVilka commented Jan 10, 2023

@MalhotraPulak do you plan to work on this any time soon?

@XVilka XVilka added the Waiting-For: Author This issue or PR is awaiting for a response or action from the author label Jan 10, 2023
@XVilka XVilka modified the milestones: 2.2, 2.3 Jan 18, 2023
@XVilka XVilka modified the milestones: 2.3, 2.4 Jul 3, 2023
@XVilka XVilka modified the milestones: 2.4, 2.5 Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting-For: Author This issue or PR is awaiting for a response or action from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants