Show available flags and comments in hexdump (#1471)

[dhavalpur0hit]

Your checklist for this pull request

• I've read the guidelines for contributing to this repository
• I made sure to follow the project's coding style
• I've updated the documentation with the relevant information (if needed)

Detailed description

Functional Changes

• Displays the flags and comments in the Information tab of the hexdump sidebar for the current address.

Code Changes
HexdumpWidget.ui:

• Added ui item elements under hexSideTab_2 for displaying flags and comments.

HexdumpWidget.cpp:

• Set the placeholder text for the flag and comment elements using setPlaceholderText.
• Created a new function showMetaInfo(RVA address):
  • Fetched the flags info for the address using r_flag_get_i (core->flags, address)
  • Fetched the comments for the address using Core()->cmd("CC." + RAddressString(address)
  • Set the fetched values for the UI elements using setText.
• Invoked showMetaInfo whenever positionChanged signal is emitted.

Test plan (required)

• Both flag and comment are present:
  

• Only the flag is present:
  

• Only the Comment is present:
  

• Both flag and comment are not present:
  

Closing issues
Closes #1471

[dhavalpur0hit]

@karliss, please review this.

[karliss]

This way of displaying the flag and comment seems very inconvenient to me, but I'd like to hear other opinions.

[radare]

see the pxa command

…

On Mon, 23 Mar 2020 at 13:07, karliss ***@***.***> wrote: This way of displaying the flag and comment seems very inconvenient to me, but I'd like to hear other opinions. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/radareorg/cutter/pull/2111#issuecomment-602552114>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG75FQ2L6JWOW4IOQHG3J3RI5GIXANCNFSM4LR2CZ3Q> .

-- --pancake

[karliss]

@dhaval0894 , we appreciate the contribution but unfortunately your current implementation provides little improvement over just opening a synchronized disassembly widget next to hexwidget. You can read the ideas for how it could look in #1471. pxa suggested by radare and right side of wxHexEditor screenshot in https://github.com/radareorg/cutter/issues/1945#issuecomment-598116829 are also good ideas.