Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Test Suite #1345

Draft
wants to merge 17 commits into
base: dev
Choose a base branch
from
Draft

[WIP] Test Suite #1345

wants to merge 17 commits into from

Conversation

thestr4ng3r
Copy link
Member

@thestr4ng3r thestr4ng3r commented Mar 20, 2019

Fix #1263

@ITAYC0HEN ITAYC0HEN added the Waiting-For: Author This issue or PR is awaiting for a response or action from the author label Dec 13, 2019
@yossizap yossizap marked this pull request as draft December 19, 2020 16:13
@thestr4ng3r
Copy link
Member Author

A suggestion since you are currently working on it: I think now it would be better to put tests in /test instead of /src/test to clearly separate them from the actual source.

export PKG_CONFIG_PATH="$CUSTOM_BREAKPAD_PREFIX/lib/pkgconfig:${PKG_CONFIG_PATH:-}" #
export PKG_CONFIG_PATH="$CUSTOM_BREAKPAD_PREFIX/lib/pkgconfig:${PKG_CONFIG_PATH:-}"
export QT_QPA_PLATFORM=minimal
export LD_LIBRARY_PATH=./Rizin-prefix/lib:$LD_LIBRARY_PATH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is LD_LIBRARY_PATH still necessary? At least in my local build CMake was setting RPATH correctly that build output is runable without modifying LD_LIBRARY_PATH.

@karliss
Copy link
Member

karliss commented Dec 20, 2020

I have mixed feelings about the way AutoTest.h handles multiple test classes. On one hand I am not too happy about idea of an executable per test files, on the other it breaks QtCreator integration and some of the Qt Test framework functionality. Haven't checked how it affects Visual Studio and KDevelop integration.

Since DECLARE_TEST it is still necessary having everything in single executable doesn't save any work when creating a new test. Running all the executables can be handled using CMake.

Biggest potential downside of multiple test executables is the performance impact of running a bunch of executables. Since it is one executable per test class not test function it shouldn't be as bad as what happens when using gtest_add_tests functionality for CTest and GTest integration. So this might not be too much of a problem.

@thestr4ng3r thestr4ng3r changed the base branch from master to dev December 21, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting-For: Author This issue or PR is awaiting for a response or action from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate test frameworks and add automated tests for Qt
4 participants