Fix: canvas's context2d property update timing #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DanEscamilla, we must merge this PR into our upstream repository. This will require a member of the Rive team to co-author this change with you. We'll let you know when that has been pushed downstream to this repository, and then we can close this issue. Thanks for the contribution! |
rive-engineering
pushed a commit
that referenced
this pull request
Jul 24, 2024
Community PR, coming from: #362 Diffs= af137aeb0 Fix: canvas's context2d property update timing (#7674) Co-authored-by: Daniel Carbajal <[email protected]> Co-authored-by: Gordon <[email protected]>
|
The commit with your contribution is here @DanEscamilla : 0509735 We'll close this PR, and create a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to fix the issue detailed in #360.
The issue stems from the native context2d calls being queued up to be executed later. This creates a rift between the draw calls and the setting of properties.
The proposed solution creates a closure for each property setter call and adds it to the draw queue, ensuring that the order of the draw calls and the property setters remains consistent chronologically.