Skip to content

Commit

Permalink
Improve collapse propagation for solo.
Browse files Browse the repository at this point in the history
Fixes https://2dimensions.slack.com/archives/CLLCU09T6/p1692895941301969

Should also address #5888

Basically we were propagating the collapse to the ClippingShape for the solo which meant that the update on the clip was never called. This meant the path would never be generated and so our contents would always get clipped out (no intersection with an empty path).

ClippingShapes and Constraints should be treated more like siblings (or properties) of the Solo instead of children that can be collapsed by the active solo child choice.

Diffs=
e1b9d360b Improve collapse propagation for solo. (#5890)
  • Loading branch information
luigi-rosso committed Aug 25, 2023
1 parent 8db282a commit d02fb10
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2719b146328ddd2136232d0756ad59f3d0facc2d
e1b9d360b4ab7a2620f888cb9b4497d253e1da80
2 changes: 1 addition & 1 deletion wasm/submodules/rive-cpp

0 comments on commit d02fb10

Please sign in to comment.