Skip to content

Commit

Permalink
Fix follow path contention with MetricsPath
Browse files Browse the repository at this point in the history
Building contour measures on the follow path constraint to remove contention on stored contour measures in the MetricsPath.

We were storing the contour data used for measuring on the MetricsPath. Calling computeLength with a different transform would mutate that stored contour data. So having the trim path and the FollowPathConstraint call computeLength with different transforms was causing problems as neither of them was guaranteed the contour data was for the correct transform they expected.

I fixed this by having the FollowPathConstraint store its own contours for the path.

Diffs=
033489f8b Fix follow path contention with MetricsPath (#5868)
  • Loading branch information
luigi-rosso committed Aug 23, 2023
1 parent d93b18a commit 22994d1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
d75d43c73b28e956a3a309757a24e4508a13c495
033489f8bb031318adc12cd418dde42e89635061
2 changes: 1 addition & 1 deletion wasm/submodules/rive-cpp

0 comments on commit 22994d1

Please sign in to comment.