Skip to content

Commit

Permalink
Update iOS release artifact actions to v4
Browse files Browse the repository at this point in the history
iOS release builds were starting to fail because we were using deprecated versions, so this updates them to v4, as suggested by blog posts discussing the deprecations (linked in the failing actions).

Diffs=
184a113c5 Update iOS release artifact actions to v4 (#8116)

Co-authored-by: David Skuza <[email protected]>
  • Loading branch information
dskuza and dskuza committed Sep 10, 2024
1 parent 2787cd9 commit 4efe5ea
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
20 changes: 10 additions & 10 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
run: agvtool new-marketing-version ${{ needs.determine_version.outputs.version }}

- name: Upload versionFiles
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: version-files
path: |
Expand All @@ -116,13 +116,13 @@ jobs:
run: echo "::set-output name=checksum::$(swift package compute-checksum archive/RiveRuntime.xcframework.zip)"

- name: Upload xcFramework
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: RiveRuntime.xcframework.zip
path: archive/RiveRuntime.xcframework.zip

- name: Upload versionFiles
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: version-files
path: |
Expand Down Expand Up @@ -171,12 +171,12 @@ jobs:
RELEASE_VERSION: ${{ needs.determine_version.outputs.version }}

- name: Upload podspec file
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: RiveRuntime.podspec
path: RiveRuntime.podspec
- name: Upload PrivacyInfo file
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: PrivacyInfo.xcprivacy
path: Resources/
Expand All @@ -187,15 +187,15 @@ jobs:
git config --local user.name ${{ github.actor }}
- name: Download versionFiles
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: version-files

- name: Add & commit version files (might want to look into doing this in release-it)
run: git add RiveRuntime.podspec Package.swift Source/Info.plist Tests/Info.plist && git commit -m "Updating version files"

- name: Download framework artifact
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
name: RiveRuntime.xcframework.zip
path: archive/
Expand Down Expand Up @@ -227,17 +227,17 @@ jobs:
needs: [determine_version, build_framework, do_release]
steps:
- name: Download framework artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: RiveRuntime.xcframework.zip

- name: Download podspec file
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: RiveRuntime.podspec

- name: Download PrivacyInfo file
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: PrivacyInfo.xcprivacy
path: Resources/
Expand Down
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
bbec5cbbcce1ab111261066f885b0d46ecee4186
184a113c5667de6b8d60f2ec444933ba5071d124

0 comments on commit 4efe5ea

Please sign in to comment.