Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaking issue when add lifecycle observer #296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hoangthan
Copy link

@hoangthan hoangthan commented Jun 24, 2023

Since the context is using ActivityLifeCycle. So trying to add lifeCycleObserver without remove when the view is being detached will causing leak memory issue.

The lifeCycleObserver is already remove itself once the lifeCycle is reached onDestroyed. But with activity, it will be never called until the activity is going on destroyed.

@umberto-sonnino
Copy link
Contributor

Since the context is using ActivityLifeCycle. So trying to add lifeCycleObserver without remove when the view is being detached will causing leak memory issue.

The lifeCycleObserver is already remove itself once the lifeCycle is reached onDestroyed. But with activity, it will be never called until the activity is going on destroyed.

The behavior for this flow has now been revised and adjusted by re-evaluating the LifecycleOwner on attach. Do you still the leak on the latest version?

@stevezuju
Copy link

Since the context is using ActivityLifeCycle. So trying to add lifeCycleObserver without remove when the view is being detached will causing leak memory issue.
The lifeCycleObserver is already remove itself once the lifeCycle is reached onDestroyed. But with activity, it will be never called until the activity is going on destroyed.

The behavior for this flow has now been revised and adjusted by re-evaluating the LifecycleOwner on attach. Do you still the leak on the latest version?

Is 5.1.5 the latest version ?

@stevezuju
Copy link

Since the context is using ActivityLifeCycle. So trying to add lifeCycleObserver without remove when the view is being detached will causing leak memory issue.
The lifeCycleObserver is already remove itself once the lifeCycle is reached onDestroyed. But with activity, it will be never called until the activity is going on destroyed.

The behavior for this flow has now been revised and adjusted by re-evaluating the LifecycleOwner on attach. Do you still the leak on the latest version?

The life-cycler you're using is activity lifecycle. The observer will be never removed in case activity not going on destroyed.
You should remove the observer while the RiveTextureView is going to detached.

@umberto-sonnino
Copy link
Contributor

Since the context is using ActivityLifeCycle. So trying to add lifeCycleObserver without remove when the view is being detached will causing leak memory issue.
The lifeCycleObserver is already remove itself once the lifeCycle is reached onDestroyed. But with activity, it will be never called until the activity is going on destroyed.

The behavior for this flow has now been revised and adjusted by re-evaluating the LifecycleOwner on attach. Do you still the leak on the latest version?

The life-cycler you're using is activity lifecycle. The observer will be never removed in case activity not going on destroyed. You should remove the observer while the RiveTextureView is going to detached.

The latest version is 6.0.0, is that what you're using?
Changes were introduced here but we're not referencing the Activity directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants