Skip to content

Commit

Permalink
Clipping and baseline
Browse files Browse the repository at this point in the history
The way we were computing the bounds for clipping was off which also exposed it was off in the runtime for transform constraints! This was also breaking the Lottie converter.

Now the origin, baseline, bounds, and clipping all look right in Flutter + C++. Goldens would help here too @mjtalbot

<img width="1152" alt="CleanShot 2023-08-02 at 11 50 36@2x" src="https://github.com/rive-app/rive/assets/454182/5b7d580e-9d82-4e7b-8b91-7155a2c89fa6">

Fixes #5732
Fixes issue discussed here: https://2dimensions.slack.com/archives/CLLCU09T6/p1690977600095549

Diffs=
d3e75b38d Clipping and baseline (#5734)
  • Loading branch information
luigi-rosso committed Aug 2, 2023
1 parent aa3b4e1 commit 32d7fc7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
50f10716b207df37bf5e9203cfd87a36812ad76b
d3e75b38d209bf0b85f2e243a6ef599ebf144acd
2 changes: 1 addition & 1 deletion .rive_renderer
Original file line number Diff line number Diff line change
@@ -1 +1 @@
e404d3d4405299b109d5cf06e584db9b5eb927bc
6e6f2cca15f2d1e1765f59e5b757b23ec54c5c87
2 changes: 1 addition & 1 deletion submodules/rive-cpp

0 comments on commit 32d7fc7

Please sign in to comment.