Search by several fields #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 28, 2017
|
|
||
| def param_to_array(s) | ||
| return s if s.kind_of?(Array) | ||
| return [s] |
There was a problem hiding this comment.
Redundant return detected.
| @@ -78,6 +91,11 @@ def postgres?(model) | |||
| # Figure out if this particular model uses the PostgreSQL adapter | |||
| model.connection.class.to_s.match(/PostgreSQLAdapter/) | |||
| end | |||
|
|
|||
| def param_to_array(s) | |||
| return s if s.kind_of?(Array) | |||
There was a problem hiding this comment.
Prefer Object#is_a? over Object#kind_of?.
| @@ -78,6 +91,11 @@ def postgres?(model) | |||
| # Figure out if this particular model uses the PostgreSQL adapter | |||
| model.connection.class.to_s.match(/PostgreSQLAdapter/) | |||
| end | |||
|
|
|||
| def param_to_array(s) | |||
There was a problem hiding this comment.
Inconsistent indentation detected.
| @@ -43,7 +52,11 @@ def get_autocomplete_select_clause(model, method, options) | |||
| ] + (options[:extra_data].blank? ? [] : options[:extra_data])) | |||
| else | |||
| table_name = model.table_name | |||
| (["#{table_name}.#{model.primary_key}", "#{table_name}.#{method}"] + (options[:extra_data].blank? ? [] : options[:extra_data])) | |||
| l = ["#{table_name}.#{model.primary_key}"] | |||
| param_to_array(method).each do |method| | |||
There was a problem hiding this comment.
Shadowing outer local variable - method.
| order << active_record_get_autocomplete_order(method, options, model) | ||
| end | ||
|
|
||
| items = items.where(clauses.join(' OR '), *conditions).limit(limit).order(order.join(', ')) |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [99/80]
|
|
||
| clauses = [] | ||
| conditions = [] | ||
| param_to_array(method).each do |method| |
There was a problem hiding this comment.
Shadowing outer local variable - method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports autocompletion search by several fields/methods at a time.
ActiveRecord only