Fix #45 Make scopes option can accepts Proc #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scopes can also override the select and where.
So you can use code like following to query unique result.
autocomplete :item, :brand, full: true, scopes: [-> { unscope(:select).select('MIN(id) as id, brand').group(:brand) }]
| end | ||
| base + ( options[:extra_data] || [] ) |
There was a problem hiding this comment.
Space inside parentheses detected.
|
I hate @houndci 😆 |
| items = items.select(get_autocomplete_select_clause(model, method, options)) unless options[:full_model] | ||
| items = items.where(get_autocomplete_where_clause(model, term, method, options)). | ||
| limit(limit).order(order) | ||
| items = items.where(where) unless where.blank? | ||
|
|
||
| if options[:unique] | ||
| scopes << -> { |
There was a problem hiding this comment.
Avoid using {...} for multi-line blocks.
Use the lambda method for multi-line lambdas.
lingceng
force-pushed
the
master
branch
2 times, most recently
from
af87021
to
1bfc32b
Compare
Use unique option to remove dulidate result:
autocomplete :item, :brand, full: true, unique: true
| items = items.select(get_autocomplete_select_clause(model, method, options)) unless options[:full_model] | ||
| items = items.where(get_autocomplete_where_clause(model, term, method, options)). | ||
| limit(limit).order(order) | ||
| items = items.where(where) unless where.blank? | ||
|
|
||
| if options[:unique] | ||
| scopes << lambda do | ||
| select = "MIN(#{model.primary_key}) as #{model.primary_key}, #{method}" |
There was a problem hiding this comment.
Line is too long. [83/80]
|
Any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scopes can also override the select and where.
So you can use code like following to query unique result.