Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update madsim-aws-s3-sdk #10700

Merged
merged 2 commits into from
Jul 3, 2023
Merged

chore(deps): update madsim-aws-s3-sdk #10700

merged 2 commits into from
Jul 3, 2023

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Jul 3, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Closes #10494

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@kwannoel
Copy link
Contributor Author

kwannoel commented Jul 3, 2023

I currently encounter this error after compiling it:

error[E0507]: cannot move out of `part.body` which is behind a shared reference
   --> /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-aws-sdk-s3-0.2.24+0.28/src/server/service.rs:330:45
    |
330 | ...                   body.extend(part.body);
    |                                   ^^^^^^^^^ move occurs because `part.body` has type `bytes::Bytes`, which does not implement the `Copy` trait

error[E0507]: cannot move out of `part.body` which is behind a shared reference
   --> /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-aws-sdk-s3-0.2.24+0.28/src/server/service.rs:334:41
    |
334 | ...                   body.extend(part.body);
    |                                   ^^^^^^^^^ move occurs because `part.body` has type `bytes::Bytes`, which does not implement the `Copy` trait

This seems weird to me because the madsim repository shows the build completes just fine. Any ideas? @wangrunji0408

@kwannoel
Copy link
Contributor Author

kwannoel commented Jul 3, 2023

Seems like it is outdated code being compiled for some reason.. it should be:

                                body.extend(&part.body);
                                break;
                            }
                        } else {
                            body.extend(&part.body);
                            break;
 

in the latest version.

@wangrunji0408
Copy link
Contributor

Sorry, I published a buggy version. 🥵
You can run cargo update -p madsim-aws-sdk-s3 again and update it to v0.2.25+0.28 to fix this.

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #10700 (c027be9) into main (5e0386f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #10700      +/-   ##
==========================================
- Coverage   70.32%   70.31%   -0.01%     
==========================================
  Files        1291     1291              
  Lines      220338   220338              
==========================================
- Hits       154943   154940       -3     
- Misses      65395    65398       +3     
Flag Coverage Δ
rust 70.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 8f6df77 Jul 3, 2023
@kwannoel kwannoel deleted the kwannoel/fix-sim branch July 3, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build delete range aggregator Magic number mismatch: expected
2 participants