Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support GetProperty #24

Merged
merged 2 commits into from
Jun 5, 2024
Merged

feat: support GetProperty #24

merged 2 commits into from
Jun 5, 2024

Conversation

Gogomoe
Copy link
Collaborator

@Gogomoe Gogomoe commented Jun 5, 2024

What's changed and what's your intention?

In most cases we don't need to get all properties.
So try to support GetProperty

Checklist

  • I have written the necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@Gogomoe Gogomoe requested review from wjf3121 and CAJan93 June 5, 2024 08:51
Copy link
Contributor

@wjf3121 wjf3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (8f1d2ab) to head (ef75f51).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   85.87%   86.33%   +0.45%     
==========================================
  Files           4        4              
  Lines         538      556      +18     
==========================================
+ Hits          462      480      +18     
  Misses         72       72              
  Partials        4        4              
Flag Coverage Δ
unittests 86.33% <100.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gogomoe Gogomoe merged commit e59a5ad into main Jun 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants