Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vlenb register #607

Merged
merged 12 commits into from
Oct 29, 2024
Merged

Remove vlenb register #607

merged 12 commits into from
Oct 29, 2024

Conversation

rez5427
Copy link
Contributor

@rez5427 rez5427 commented Oct 25, 2024

Sorry about the messy commit

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

Test Results

396 tests  ±0   396 ✅ ±0   0s ⏱️ ±0s
  4 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 6a7ae1b. ± Comparison against base commit 1b2d498.

♻️ This comment has been updated with latest results.

@rez5427
Copy link
Contributor Author

rez5427 commented Oct 25, 2024

fix #565

arichardson
arichardson approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

History needs squashing change looks sensible.

model/riscv_sys_control.sail Outdated Show resolved Hide resolved
jordancarlin
jordancarlin approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@jordancarlin jordancarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to define vlen as unsigned(get_vlenb()) * 8 since that is how vlenb is used so often, but that can be a later PR. This looks like a nice clean up as is.

@rez5427
Copy link
Contributor Author

rez5427 commented Oct 26, 2024

fix #574

@rez5427
Copy link
Contributor Author

rez5427 commented Oct 27, 2024

Might be nice to define vlen as unsigned(get_vlenb()) * 8 since that is how vlenb is used so often, but that can be a later PR. This looks like a nice clean up as is.

like this?

jordancarlin
jordancarlin approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@jordancarlin jordancarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this?

Yes. Looks good to me now.

Timmmm
Timmmm approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@Timmmm Timmmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, LGTM!

@Timmmm Timmmm merged commit 9d86f01 into riscv:master Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timmmm Timmmm Timmmm approved these changes

@arichardson arichardson arichardson approved these changes

@jordancarlin jordancarlin jordancarlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rez5427 @Timmmm @arichardson @jordancarlin @Yui5427