Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge with updates #586

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Merge with updates #586

merged 4 commits into from
Oct 11, 2024

Conversation

rez5427
Copy link
Contributor

@rez5427 rez5427 commented Oct 10, 2024

issues #583

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

Test Results

396 tests  ±0   396 ✅ ±0   0s ⏱️ ±0s
  4 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 2fbe2ee. ± Comparison against base commit f7192a6.

♻️ This comment has been updated with latest results.

Timmmm
Timmmm requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@Timmmm Timmmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! Just a couple of minor nits and then we can merge it.

model/riscv_sys_regs.sail Outdated Show resolved Hide resolved
model/riscv_sys_regs.sail Outdated Show resolved Hide resolved
model/riscv_sys_regs.sail Outdated Show resolved Hide resolved
model/riscv_sys_regs.sail Outdated Show resolved Hide resolved
@Timmmm
Copy link
Collaborator

Timmmm commented Oct 10, 2024

Thanks! I'll merge this tomorrow.

arichardson
arichardson approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

History is messy but as long as this is squash-merged with a sensible commit message it LGTM.

@Timmmm Timmmm merged commit 89b8e0c into riscv:master Oct 11, 2024
2 checks passed
@jordancarlin jordancarlin mentioned this pull request Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timmmm Timmmm Timmmm approved these changes

@arichardson arichardson arichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rez5427 @Timmmm @arichardson @Yui5427