-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove N extension #584
Remove N extension #584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was one of the two awkward extensions that made my modularisation attempt tricky, so I'm not too sad that it's gone
Yeah it's making writing CLIC a pain too, e.g. it's difficult to make a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking at moving the CSRs to actually be scattered, and this was causing compilation order issues for that too. Will be great to get rid of it since it touches so many parts of the model.
@Timmmm There's absolutely nothing wrong with anything you've done. On the contrary, I'm quite pleased and grateful that you've managed to help resolve the conflicts when merge into master. Similarly, I do hope this PR can be merged and make a valuable contribution to our gold model. |
@billmcspadden-riscv any objection to merging this? |
I think we've got good agreement on this anyway and it will make Alasdair and Jordan's lives easier so I'll merge it on Thursday if nobody objects before then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
However, I would not be surprised if this extension does not raise its head again.
It's been kicked around for at least 5 years and at one point, someone important swore that it would be ratified "real soon now".
Looks like there are some conflicts that must be resolved.
Bill Mc.
…On Tue, Oct 15, 2024 at 3:26 AM Tim Hutt ***@***.***> wrote:
I think we've got good agreement on this anyway and it will make Alasdair
and Jordan's lives easier so I'll merge it on Thursday if nobody objects
before then.
—
Reply to this email directly, view it on GitHub
<#584 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXROLOCOGHXRF2XNQKHM2QDZ3TGRZAVCNFSM6AAAAABPUSASEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTGIZDCMBTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Bill McSpadden
Formal Verification Engineer
RISC-V International
mobile: 503-807-9309
Join me at RISC-V Summit North America <http://www.riscvsummit.com/> in
October!
|
This extension was never ratified, has been removed from the ISA manual and apparently would need significant changes if it were to ever come back. Therefore it makes sense to remove it from the model in order to simplify the code.
f0e844b
to
eac9139
Compare
This extension was never ratified, has been removed from the ISA manual and apparently would need significant changes if it were to ever come back.
Therefore it makes sense to remove it from the model in order to simplify the code.
This was written by @KotorinMinami in #531, I then made some minor formatting changes and some refactoring of the interrupt handling in this commit, and finally rebased it.