Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MEnvCall value #438

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

Timmmm
Copy link
Collaborator

@Timmmm Timmmm commented Mar 19, 2024

Fixes #294

Copy link

Test Results

712 tests  ±0   712 ✅ ±0   0s ⏱️ ±0s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit b069d85. ± Comparison against base commit c287c34.

@arichardson
Copy link
Collaborator

Surprised this wasn't caught by any kind of testing before

@jrtc27
Copy link
Collaborator

jrtc27 commented Mar 19, 2024

ECALLing from M-mode is a weird thing to do, and I guess TestRIG doesn’t have an ECALL template?

@Timmmm
Copy link
Collaborator Author

Timmmm commented Mar 20, 2024

ECALLing from M-mode is a weird thing to do

A colleague suggested it can be used for context switching for embedded OSes that run entirely in machine mode. E.g. I think here is where it is used on FreeRTOS.

@billmcspadden-riscv
Copy link
Collaborator

I'm looking at the priv spec for medeleg, but I am not finding a bitfield definition for the CSR. Where are the bitfields defined?

@billmcspadden-riscv billmcspadden-riscv added the tgmm-agenda Tagged for the next Golden Model meeting agenda. label Mar 25, 2024
@Timmmm
Copy link
Collaborator Author

Timmmm commented Mar 25, 2024

Here:

image

@billmcspadden-riscv billmcspadden-riscv merged commit d564b93 into riscv:master Mar 25, 2024
2 checks passed
@Timmmm Timmmm deleted the user/timh/menvcall branch April 4, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tgmm-agenda Tagged for the next Golden Model meeting agenda.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Medeleg MEnvCall is bit 10 but it should be bit 11.
4 participants