Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove effect annotations from vector extension #367

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Remove effect annotations from vector extension #367

merged 1 commit into from
Dec 6, 2023

Conversation

Alasdair
Copy link
Collaborator

@Alasdair Alasdair commented Dec 3, 2023

We removed these a while ago from everything else, but I guess it didn't happen for vector because it was on a branch.

Removes the warning these produce.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

Test Results

712 tests  ±0   712 ✔️ ±0   0s ⏱️ ±0s
    6 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 2b9c990. ± Comparison against base commit 153f983.

billmcspadden-riscv
billmcspadden-riscv approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@billmcspadden-riscv billmcspadden-riscv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@billmcspadden-riscv billmcspadden-riscv merged commit 28fb465 into riscv:master Dec 6, 2023
2 checks passed
@Alasdair Alasdair deleted the vector_effect branch December 15, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timmmm Timmmm Timmmm approved these changes

@billmcspadden-riscv billmcspadden-riscv billmcspadden-riscv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alasdair @Timmmm @billmcspadden-riscv