Constrain TLB struct bit sizes #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constraining them to <= 64 bits generates code that doesn't use GMP and is therefore much faster. This massively increases C emulation performance.
|
LGTM 👍 Better bitvector length monomorphisation is on my agenda for the Sail -> SystemVerilog model checking path so maybe in the future this will not be needed. That may be a way off yet, so I'm not saying that as a reason to not merge this. |
|
@Timmmm should the |
It wasn't really the intent of this change to impose architectural restrictions; just to make Sail generate better C types, and only 64 is necessary for that. I think I'd prefer to leave it as 64 so the intent is clear and this code can be removed if/when Sail uses "small bitvector optimisation". |
|
(Or more monomorphisation as Alasdair mentioned.) |
|
I think this is no longer needed? If so can we close the pr? |
|
Yep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constraining them to <= 64 bits generates code that doesn't use GMP and is therefore much faster. This massively increases C emulation performance.