Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lem build error #315

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix lem build error #315

merged 1 commit into from
Oct 11, 2023

Conversation

Alasdair
Copy link
Collaborator

This should fix the build error that has been reported, although I think in general typing 'make' just does too much by default.

@Alasdair
Fix lem build error
12a549c 
The speculate_conditional should be marked monadic. It would seem like
the various _reservation functions should be also, but it seems like
perhaps they are not implemented in lem right now.
@github-actions
Copy link

Unit Test Results

712 tests  ±0   712 ✔️ ±0   0s ⏱️ ±0s
    6 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 12a549c. ± Comparison against base commit dbea780.

billmcspadden-riscv
billmcspadden-riscv approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@billmcspadden-riscv billmcspadden-riscv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the discussion at the tech-golden-model meeting on 2023-10-10, this should be approved and merged.
Alasdair's comment about "make just does too much by default" will be handled in a separate issue/PR.

@billmcspadden-riscv billmcspadden-riscv merged commit 532714a into riscv:master Oct 11, 2023
2 checks passed
@billmcspadden-riscv billmcspadden-riscv mentioned this pull request Oct 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billmcspadden-riscv billmcspadden-riscv billmcspadden-riscv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alasdair @billmcspadden-riscv