Add convenience targets for dual simulator builds #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrtc27
requested changes
Sep 23, 2023
|
@jrtc27 what are the issues you see with the changes I have submitted? I would appreciate if you point the problems instead of just sending your version. |
|
It’s targeted at just csim and papers over the mess that is how ARCH is dealt with. |
|
@jrtc27 as you have not submited your better version I will move forwad with the version I have submited. This is blocking a bunch of other improvements. @billmcspadden-riscv who else can review this? |
billmcspadden-riscv
added
the
tgmm-agenda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces convenience targets that allow building both simulator binaries with a single command:
make csim_all.