Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clicintattr.mode should not be writable from S-mode #424

Open
christian-herber-nxp opened this issue Oct 4, 2024 · 1 comment
Open

clicintattr.mode should not be writable from S-mode #424

christian-herber-nxp opened this issue Oct 4, 2024 · 1 comment
Assignees
Labels
v1.0 resolve for 1.0

Comments

@christian-herber-nxp
Copy link
Collaborator

Looks like a security hole to me. If M-mode assign an interrupt to S-mode, it does not sound ok for S-mode to throw that back. Seems like an easy way to corrupt M-mode.

I would suggest adding something along the lines of:

When in mode x, it is only allowed to write values to clicintattr.mode which correspond to equally or less privileged modes. Writing other values is reserved.

(Please help me with the language)

@christian-herber-nxp
Copy link
Collaborator Author

I overlooked the following note:

For security purpose, the mode field can only be set to a privilege mode that is equal to or lower than the currently running privilege mode and if interrupts are supported at that privilege mode (e.g. ssclic extension).

This should not be a note, but part of the normative spec.

@jb-brelot-nxp jb-brelot-nxp added the v1.0 resolve for 1.0 label Oct 7, 2024
@jb-brelot-nxp jb-brelot-nxp self-assigned this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.0 resolve for 1.0
Projects
None yet
Development

No branches or pull requests

2 participants