Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The smclicshv extension naming (i.e. sm*) suggests it only has M-mode features but it affects S-mode and has one S-mode CSR bit #421

Open
james-ball-qualcomm opened this issue Sep 30, 2024 · 4 comments
Assignees
Labels
reorg Reorganization for Priv ISA manual integration v1.0 resolve for 1.0

Comments

@james-ball-qualcomm
Copy link
Collaborator

The smclicshv extension naming (i.e. sm*) suggests it only has M-mode features. Does it have S-mode features too? I ask because the smclicshv chapter uses the 'x' prefix notation instead of 'm'. What gives?

@jb-brelot-nxp
Copy link
Collaborator

From my side this extension is affecting all mode supported by the CLIC.

If CLIC is supporting only M mode, then this extension will affect only M registers
If CLIC is supporting M and S mode, then this extension will affect M and S mode.

As soon as you get Selective Hardware vectoring supported on M mode, the cost to support it for S is for free.
So x prefix is the good one from my side.

Maybe I forget some aspects. We can discuss this tonight.

@christian-herber-nxp
Copy link
Collaborator

i think there is no precedent for an x prefix in an extension.
the normal thing to do is to have a smclicshv and a ssclicshv.
However, here we do not want them to be selectable individually.
So if smclicshv and sslic are supported, ssclicshv is mandatory. Otherwise, ssclicshv is forbidden.

@james-ball-qualcomm
Copy link
Collaborator Author

Precedent in Priv ISA manual:

Chapter 5. "Smcsrind/Sscsrind" Indirect CSR Access, Version 1.0.0
5.1. Introduction
Smcsrind/Sscsrind is an ISA extension that extends the indirect CSR access mechanism originally
defined as part of the Smaia/Ssaia extensions, in order to make it available for use by other extensions
without creating an unnecessary dependence on Smaia/Ssaia.
This extension confers two benefits:

@james-ball-qualcomm
Copy link
Collaborator Author

Another:

Chapter 4. "Smstateen/Ssstateen" Extensions, Version 1.0.0

@jb-brelot-nxp jb-brelot-nxp added reorg Reorganization for Priv ISA manual integration v1.0 resolve for 1.0 labels Oct 7, 2024
@jb-brelot-nxp jb-brelot-nxp self-assigned this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reorg Reorganization for Priv ISA manual integration v1.0 resolve for 1.0
Projects
None yet
Development

No branches or pull requests

3 participants