-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zacas extension #492
Add Zacas extension #492
Conversation
@ved-rivos did you make sure these can run on Spike? |
I have tested them on sail but not on spike. |
Good enough for me. |
Actually, good enough for me to believe the test cases are correct, but not good enough for being able to merge this :) We need it to be the case that executing |
Thanks. These and all other tests pass on spike but the breakpoint.S test seems to be failing. I am not sure if I caused it (I most likely did not since I only added amocas tests :) ). I will update the PR after that debug that to be sure. |
Updated PR to extend the ISA string (breakpoint.S failure seems unrelated to addition of these tests). |
Thanks, @ved-rivos. I’m sure you’re right, and I’ll look into the breakpoint test failure myself. |
@aswaterman - Found some time to look at this today. Seems like the test was not factoring in the case that when |
@ved-rivos sorry we forgot to finish this up. If it's fully working now, LMK. |
This PR adds tests for the Zacas extension that introduces the following instructions:
The specification is here: https://github.com/riscv/riscv-zacas
The amocas instructions are emitted using a .word directive pending assembler support.