Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the latest version of riscv-gcc, the benchmarks compile incorrectly:
memset()
is compiled with a recursive call, just as described in riscvarchive/riscv-gcc#197. This leads to an infinite recursion and ultimately to a crash due to a stack overflow. Here is the corresponding part ofdhrystone.riscv.dump
compiled with the latest versions of riscv-tests and riscv-gcc:As suggested in riscvarchive/riscv-gcc#197, compiling with
-fno-builtin
resolves this issue. However, I could not check how this impacts performance across platforms.