New gen_layout commands #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kathlenemagnus can I get a "heck ya!" approval for this? |
kathlenehurt-sifive
approved these changes
Nov 10, 2023
ghost
requested a review
from
kathlenehurt-sifive
approved these changes
Nov 13, 2023
kathlenemagnus
approved these changes
Nov 13, 2023
aarongchan
pushed a commit
to aarongchan/riscv-perf-model
that referenced
this pull request
Nov 17, 2023
Removed the old perl generator; uses the new python generator in Sparta. These changes make a few assumptions: 1. The user is using a newer version of sparta map_v2 2. The path to the clone of map is next to the clone of olympia
|
Hi Knute - I run into problems with this PR, seems there are some non-ascii characters in the generated alf files that are checked in, for example in
On my end (WSL2 Ubuntu), this crashes the yaml parsing when you start the pipe viewer. I haven't been able to rerun the generate script without errors, it's not clear to me what sparta version it depends on exactly to work. |
|
Ugh, I see the escape chars -- I have no idea how that happened. I'll look at it today. You'll need map_v2.0.7 or later to run the tools. |
|
Fix in #127 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the old perl generator; uses the new python generator in Sparta.
These changes make a few assumptions: