Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the intro and appendix #62

Merged
merged 10 commits into from
Oct 8, 2024
Merged

Update the intro and appendix #62

merged 10 commits into from
Oct 8, 2024

Conversation

AoteJin
Copy link
Collaborator

@AoteJin AoteJin commented Sep 24, 2024

No description provided.

@AoteJin AoteJin requested review from bcstrongx, joxie and gokhankaplayan and removed request for bcstrongx September 24, 2024 12:15
@AoteJin AoteJin requested review from gokhankaplayan and removed request for gokhankaplayan September 24, 2024 13:00
appendix.adoc Show resolved Hide resolved
appendix.adoc Outdated Show resolved Hide resolved
appendix.adoc Outdated Show resolved Hide resolved
intro.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@pdonahue-ventana pdonahue-ventana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some wording suggestions.

appendix.adoc Outdated Show resolved Hide resolved
appendix.adoc Outdated Show resolved Hide resolved
appendix.adoc Outdated Show resolved Hide resolved
intro.adoc Outdated Show resolved Hide resolved
intro.adoc Outdated Show resolved Hide resolved
AoteJin and others added 6 commits September 25, 2024 16:57
Co-authored-by: Paul Donahue <[email protected]>
Signed-off-by: Aote Jin <[email protected]>
Co-authored-by: Paul Donahue <[email protected]>
Signed-off-by: Aote Jin <[email protected]>
Co-authored-by: Paul Donahue <[email protected]>
Signed-off-by: Aote Jin <[email protected]>
Co-authored-by: Paul Donahue <[email protected]>
Signed-off-by: Aote Jin <[email protected]>
Co-authored-by: Paul Donahue <[email protected]>
Signed-off-by: Aote Jin <[email protected]>
@AoteJin
Copy link
Collaborator Author

AoteJin commented Sep 25, 2024

Thanks @bcstrongx and @pdonahue-ventana for the feedbacks!
Let's keep the review process active for a while to get more inputs.

@AoteJin AoteJin merged commit e4cd2fc into main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants