Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTG] Add cli param env_dir #539

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[CTG] Add cli param env_dir #539

wants to merge 1 commit into from

Conversation

trdthg
Copy link
Contributor

@trdthg trdthg commented Oct 21, 2024

Description

#529 I think that a fixed env_dir either ./ or ~/riscv-arch-test/riscv-test-suite/env is not suitable for everyone anyway.

Why not set it as a new cli param?

I personally prefer to place riscv-arch-test in the current directory(test_dir) via a symbolic link, which would be ./riscv-arch-test/riscv-test-suite/env. Considering our different for the default path, I just casually wrote a ./ here.

@UmerShahidengr
Copy link
Collaborator

This will change the script to run CTG, all scripts will now require a new command line parameter otherwise existing scripts will stop working, I don't recommend such changes which will affect all users without proper discussion and documentation. This will require changes in the documentation and announcement for everyone that a new CLI parameter has been added.

@trdthg
Copy link
Contributor Author

trdthg commented Oct 21, 2024

what about keep the default value to ~/riscv-arch-test/riscv-test-suite/env
At least all scripts do not need to be modified

Signed-off-by: MingZhu Yan <[email protected]>
@trdthg
Copy link
Contributor Author

trdthg commented Oct 25, 2024

keep the default value to ~/riscv-arch-test/riscv-test-suite/env

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants