add fcvt testcases

[Pagerd]

Description

• Add floating-to-float conversions in Zfh tests

Related Issues

#458

Ratified/Unratified Extensions

• [✓] Ratified

List Extensions

• Zfh

Reference Model Used

• [✓] SAIL

Mandatory Checklist:

• All tests are compliant with the test-format spec present in this repo ?
• Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
• Ran the new tests on RISCOF in coverage mode
• Link to Google-Drive folder containing the new coverage reports): < coverage reports >
• Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
• Changelog entry created with a minor patch

Optional Checklist:

• RISCV-V CTG PR link if tests were generated using it : < SPECIFY HERE >
• Were the tests hand-written/modified ?
• Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
• If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

[allenjbaum]

This needs to be run in coverage mode, and have the coverpoint file pointed to. Coverpoints that have comments are highly appreciated.

…

On Tue, Jul 30, 2024 at 4:16 AM Pagerd ***@***.***> wrote: Description - Add floating-to-float conversions in Zfh tests Related Issues #458 <#458> Ratified/Unratified Extensions - [✓] Ratified - Unratified List Extensions - Zfh Reference Model Used - [✓] SAIL Mandatory Checklist: - All tests are compliant with the test-format spec present in this repo ? - Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ? - Ran the new tests on RISCOF in coverage mode <https://riscof.readthedocs.io/en/stable/commands.html#coverage> - Link to Google-Drive folder containing the new coverage reports (See this <https://github.com/riscv-non-isa/riscv-arch-test/blob/main/CONTRIBUTION.md#uploading-test-stats> for more info): < SPECIFY HERE > - Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE > - Changelog entry created with a minor patch Optional Checklist: - RISCV-V CTG PR link if tests were generated using it : < SPECIFY HERE > - Were the tests hand-written/modified ? - Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description - If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above. ------------------------------ You can view, comment on, or merge this pull request online at: #483 Commit Summary - db6b3bc <db6b3bc> add fcvt testcases File Changes (28 files <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files>) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.d.h_b1-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-a199ef11fb03ed5aa6e8a895c5e014e9f91645ab57e6a06e9caa1fcc4481b749> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.d.h_b22-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-5fc7938d73f1c3de2933825dab4fef5a244bf2c7e163956cebfd87333e740150> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.d.h_b23-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-1e0dc97d59b67897280dc8e0d7ee76d8f00135662505b2bd0c8aaf4e9baccfbf> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.d.h_b24-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-9d9f5bb9d1422b3f12d74d12b4bb8a7dff7eb3a0b2625a29d5800514db257ffc> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.d.h_b27-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-90a8fe3c20ab37aad13f3338d8d891c6cc0cf1f6320121d0115f9b921038d70e> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.d.h_b28-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-b7a14634c4bb3cc0d432029c461c048457c0b4592a9a10c0b4e92b2aadb6e19c> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.d.h_b29-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-98de8e1b04d7a7ea78831419f0755c26508ca8f37cee87877c73dd0a42d37a3b> (409) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.d_b1-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-2bf86a2cb890aaa893556cc0ccfeefeeadb1992a6bc43f4fa53d6fd44e8b81f7> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.d_b22-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-8cf5a0e02abdf5a135ad160b3e10fd2d39d6c57ef678462ce20ca71bcca445c0> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.d_b23-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-1b93a2661ae24f16f664903577f4c76c547d9cdf106bffb5fe218ea2a9b2fd4e> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.d_b24-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-dd29af55ce5e16743303d085b0c98091f9f39323d3294b60e53f87109f3d3df9> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.d_b27-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-fb175a5aefc92a3ee2f8b2e8244056b8caea535ec4f1ef8233939058cdec188c> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.d_b28-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-6df11fa4d451e495fec67b35e283828fa192b8ce2c3c35a9ac525bd892a6e4e6> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.d_b29-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-f8ba0866b5231bb5930069384c0342125235c2f722094ef5e741dc50b4fc9eed> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.s_b1-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-5d3763915444ab6897efa4e4f45d90328fd981c611937296eed952aeaecc334c> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.s_b22-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-f5dc6d36f3df75f4da14754ffe21bee1e6014d6b31f501af147799083a4b2eb6> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.s_b23-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-328218f2cc8c0c54e116e3864f0e0c3355188b9d667bf9db27d725ce0792fa9b> (449) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.s_b24-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-2869ba9329093cb10bff4ee7a55c0fd38307554f2ebf6ae2d580ac6ab59fa1cc> (929) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.s_b27-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-61ca4523e3b6828ebfe72f8f549325e2b4263ffdf821caf87649c7a752da5b59> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.s_b28-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-0aebc236bb362269be65efab5949d372076c4ce1a3b24d3f936370919d8f0f81> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.h.s_b29-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-c8ecb5c19874658ef2189d9b265293a2694c6b0660f45dbed120380e87ff2bb1> (729) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.s.h_b1-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-829b13d436e51ef696505a34ddd36711bb58c8882c01ff50b8a3a865d4a41df9> (241) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.s.h_b22-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-5ad1ba0e1e3bccbaa41bd0d9f0183bb5ab8958c0ed706cae947adb995b73af8b> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.s.h_b23-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-6d80a1827586621f50347da3cb09f36fe0553a0df4a5962b92c41d696ccbfa57> (449) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.s.h_b24-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-a58ec24271c44e7eaf712d90f08a4fb8b8463dfd9632b71e314efce217b98f58> (929) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.s.h_b27-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-872b864e4a0aa46ee578a2c7a4f3742f55f7a7993ea6105d090e671b788f0d5d> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.s.h_b28-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-a890e81700f0424e722ecd6f5b2ef987a24eb826fdee25bfd995546295272e73> (353) - *A* riscv-test-suite/rv32i_m/Zfh/src/fcvt.s.h_b29-01.S <https://github.com/riscv-non-isa/riscv-arch-test/pull/483/files#diff-ddfc5dc9b7cc5ccd87b707dd56165cafda01367a38c60bca26e81e2f74b3943c> (409) Patch Links: - https://github.com/riscv-non-isa/riscv-arch-test/pull/483.patch - https://github.com/riscv-non-isa/riscv-arch-test/pull/483.diff — Reply to this email directly, view it on GitHub <#483>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHPXVJSLNJD4XSBRZHV4VD3ZO3ZRDAVCNFSM6AAAAABLVMZUL2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZTMNZTGE2TSNQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[Pagerd]

update the coverage reports

[allenjbaum]

I'm not seeing a pointer to the .cgf files, as requested. Am I just missing it somewhere?

[Pagerd]

Sorry about missing .cgf files, I have uploaded a new compressed package in google drive

[allenjbaum]

We have a little problem here. You did include the tests, the test results, you've added the coverpoints, but       you didn't include the coverage report.
IF you had, you may have noticed that there is a lot of missing coverage, because you just copied a particular integer coverage file - and these ops all involve floating point numbers.     There is no coverage for floating point values at all, in either integer or float point formats.
You need to go back and look at how other floating point tests have defined their cover points, and how integer tests have, and craft coverpoints that match the opcodes you're testing, e.g.      for int->float conversions, you want integer value  around powers of 2 +/- offsets that will cause different roundings that bump the exponent up or down (including to infinity or to zero).    (and you want to test the ops with all the different rounding modes)
   for float-> int, you want to to something similar: test floats that are near min/max integer values (including around +/-zero) +/-small offsets, and a few others (Naans, infinity,)
The cgf file you chose is incomplete (e.g. it tests max positive/negative value, 0, 1... but never -1, which is an enormous coverage miss. Also not your fault, but all those coverpoints need to be rewritten/augmented.That cgf also includes reference to rs3, which don't even exist in the operations you're testing, so you'll never get full coverage, another reason you'll need to be more careful crafting the coverpoints.
The FP tests check for FP values in categories such as ibm_b23, and can be found reasonably well documented in the ISAC repoThere should be an equivalent for the Int dataset so the definitions don't have to get repeated over&over- also not your problem.

[allenjbaum]

Oh, also, this won't get merged into main, it must be merged into the dev branch

[Pagerd]

I understand, pr will be temporarily closed until i resolve these problem