remove duplicate RVMODEL_BOOT macro

[MarcKarasek]

This was causing compile of test suites to crash

Description

Removed RVMODEL_BOOT from arch_test.h -- This macro is already included in all of the test code (.S) files,
NOTE: Current repo from RVI is not usable and crashes during compile of the test code (.S) files.

Related Issues

Please list all the issues related to this PR. Use NA if no issues exist

Ratified/Unratified Extensions

• [X ] Ratified
• Unratified

List Extensions

List the extensions that your PR affects. In case of unratified extensions, please provide a link to the spec draft that was referred to make this PR.

Reference Model Used

• SAIL
• Spike
• [X ] Other - Ran our tests with this fix in place. Works

Mandatory Checklist:

• All tests are compliant with the test-format spec present in this repo ?
• [ X] Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
• [ X] Ran the new tests on RISCOF in coverage mode
• Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >
• Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
• Changelog entry created with a minor patch

Optional Checklist:

• RISCV-V CTG PR link if tests were generated using it : < SPECIFY HERE >
• Were the tests hand-written/modified ?
• Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
• If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

[MarcKarasek]

This is gating running our daily/weekly regression test on our DUT.

[UmerShahidengr]

Instead of removing RVMODEL_BOOT completely, I have commented that line as this is a temporary fix. Test structure will be updated in the future and RVMODEL_BOOT will be the part of trap handler instead of each test file.

[UmerShahidengr]

Its good to go

[UmerShahidengr]

@jamesbeyond since I committed in this PR so I cant merge this one. Please add your review and merge this one.

[allenjbaum]

I don't seem to be able to review this

[allenjbaum]

Super simple fix - should be good to go.

[allenjbaum]

OK, I added myself as a review and approved it. apepars to be merging.

…

On Tue, Jul 23, 2024 at 7:14 AM Umer Shahid ***@***.***> wrote: @jamesbeyond <https://github.com/jamesbeyond> since I committed in this PR so I cant merge this one. Please add your review and merge this one. — Reply to this email directly, view it on GitHub <#481 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHPXVJSE2Q4DSDVTXO42CTDZNZQN7AVCNFSM6AAAAABLF6ONFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVGM3TMOBVGI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[MarcKarasek]

Thanks, I quill update our Jenkins Jobs to point to dev.

…

On Wed, Jul 24, 2024 at 3:15 AM Allen Baum ***@***.***> wrote: OK, I added myself as a review and approved it. apepars to be merging. On Tue, Jul 23, 2024 at 7:14 AM Umer Shahid ***@***.***> wrote: > @jamesbeyond <https://github.com/jamesbeyond> since I committed in this > PR so I cant merge this one. Please add your review and merge this one. > > — > Reply to this email directly, view it on GitHub > < #481 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AHPXVJSE2Q4DSDVTXO42CTDZNZQN7AVCNFSM6AAAAABLF6ONFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVGM3TMOBVGI> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > — Reply to this email directly, view it on GitHub <#481 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD72ZM6XMTNDL3HYHBI3UMLZN5IBJAVCNFSM6AAAAABLF6ONFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBXGA3TQOJVGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- /**************** Marc Karasek ASM T648 Herder of Cats ****************/

[MarcKarasek]

Works ... just ran one of the extension tsests (A) and it now passes