Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add misaligned c.jalr and c.jr instruction test #466

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

rogerchang23424
Copy link
Contributor

@rogerchang23424 rogerchang23424 commented May 22, 2024

Description

This PR added the additional test case for c.jalr and c.jr with the misaligned address in the register to verify the implementation.

Related Issues

NA

Ratified/Unratified Extensions

  • Ratified
  • Unratified

List Extensions

List the extensions that your PR affects. In case of unratified extensions, please provide a link to the spec draft that was referred to make this PR.

Reference Model Used

  • SAIL
  • Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • All tests are compliant with the test-format spec present in this repo ?
  • Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
  • Ran the new tests on RISCOF in coverage mode
  • Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >
  • Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
  • Changelog entry created with a minor patch

Optional Checklist:

@allenjbaum
Copy link
Collaborator

Please change this to be a PR to the dev branch

@rogerchang23424
Copy link
Contributor Author

Please change this to be a PR to the dev branch

Done. Please check.

@UmerShahidengr
Copy link
Collaborator

Good work @rogerchang23424 , but we need the coverpoint definitions for these tests, otherwise riscof coverage command will not work on these tests.

@jamesbeyond jamesbeyond added unprivileged ratified ratified specs size-S Small efforts required labels Jun 6, 2024
@rogerchang23424 rogerchang23424 force-pushed the mis-cjalr branch 2 times, most recently from b565384 to e260f41 Compare June 15, 2024 00:49
@rogerchang23424
Copy link
Contributor Author

Hi, I have added the misalign1-cjalr and misalign1-cjr coverage in the separated PR. Sorry for waiting for a long time to update it.

Copy link
Collaborator

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesbeyond jamesbeyond merged commit 0bf9236 into riscv-non-isa:dev Jul 1, 2024
2 checks passed
@rogerchang23424 rogerchang23424 deleted the mis-cjalr branch July 2, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ratified ratified specs size-S Small efforts required unprivileged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants