Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo of regexp vs. regex in 6 rv32M test cases #412

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

davidharrishmc
Copy link
Contributor

Description

Fixed regexp to regex in 6 rv32M test cases broken by PR411.
The original PR was tested in a different copy of the repository, and the fixes were incorrectly transcribed into the version being merged.

Related Issues

PR411 introduced a typo reported by Mario Hoffmann

Ratified/Unratified Extensions

  • [RV32M ] Ratified
  • Unratified

List Extensions

RV32M

Reference Model Used

  • [ x] SAIL
  • Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • [x ] All tests are compliant with the test-format spec present in this repo ?
  • [x ] Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
  • [n/a ] Ran the new tests on RISCOF in coverage mode
  • [n/a ] Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >
  • [n/a ] Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
  • [x ] Changelog entry created with a minor patch

Optional Checklist:

  • RISCV-V CTG PR link if tests were generated using it : < SPECIFY HERE >
  • [y ] Were the tests hand-written/modified ?
  • Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
  • If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh- I should have checked that you had run these...

@allenjbaum allenjbaum merged commit eb0a389 into riscv-non-isa:main Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants