Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored *64 attributes to RV_TESTCASE for 7 RV64M tests #410

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

davidharrishmc
Copy link
Contributor

Description

This PR restores the *64 attribute to RV_TESTCASE for 7 RV64M tests that lost the attributed in commit 9b503d7 that was pulled yesterday. When the *64 attributes are missing, I got the following errors while running riscof.

ERROR | Error in test: /home/harris/cvwtest/cvw/addins/riscv-arch-test/riscv-test-suite/rv64i_m/M/src/divu-01.S
Test Selected without the relevant extensions being available on DUT.
ERROR | Error in test: /home/harris/cvwtest/cvw/addins/riscv-arch-test/riscv-test-suite/rv64i_m/M/src/mul-01.S
Test Selected without the relevant extensions being available on DUT.
ERROR | Error in test: /home/harris/cvwtest/cvw/addins/riscv-arch-test/riscv-test-suite/rv64i_m/M/src/mulh-01.S
Test Selected without the relevant extensions being available on DUT.
ERROR | Error in test: /home/harris/cvwtest/cvw/addins/riscv-arch-test/riscv-test-suite/rv64i_m/M/src/mulhsu-01.S
Test Selected without the relevant extensions being available on DUT.
ERROR | Error in test: /home/harris/cvwtest/cvw/addins/riscv-arch-test/riscv-test-suite/rv64i_m/M/src/mulhu-01.S
Test Selected without the relevant extensions being available on DUT.
ERROR | Error in test: /home/harris/cvwtest/cvw/addins/riscv-arch-test/riscv-test-suite/rv64i_m/M/src/rem-01.S
Test Selected without the relevant extensions being available on DUT.
ERROR | Error in test: /home/harris/cvwtest/cvw/addins/riscv-arch-test/riscv-test-suite/rv64i_m/M/src/remu-01.S
Test Selected without the relevant extensions being available on DUT.

Related Issues

N/A

Ratified/Unratified Extensions

  • [ x] Ratified
  • Unratified

List Extensions

M extension test case

Reference Model Used

  • [ x] SAIL
  • Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • [x ] All tests are compliant with the test-format spec present in this repo ?
  • [ x] Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
  • [ n/a] Ran the new tests on RISCOF in coverage mode
  • [n/a ] Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >
  • [n/a ] Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
  • [x ] Changelog entry created with a minor patch

Optional Checklist:

  • RISCV-V CTG PR link if tests were generated using it : < SPECIFY HERE >
  • Were the tests hand-written/modified ?
  • Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
  • If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what can slip through when tests are completely regenerated...

@allenjbaum allenjbaum merged commit 9f9bdd6 into riscv-non-isa:main Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants