Add read-only CSR MCONFIGPTR test #381
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mconfigptr is a read-only CSR defined in priv spec 1.12. The test attempts a read/write (illegal instruction exception expected)/read. The read data value is implementation dependent so the read data value is ignored. Signed-off-by: Dan Smathers <[email protected]>
Signed-off-by: Dan Smathers <[email protected]>
add mconfigptr csr test Signed-off-by: Dan Smathers <[email protected]>
allenjbaum
requested changes
Nov 10, 2023
There was a problem hiding this comment.
This needs 2 nops after an op that might trap, because the trap handler always returns to the following double-word aligned instruction (deliberately, so we can write tests that do different things depending on whether a trap occurred or not, in addition to writing a trap signature
|
This also needs a coverage definition, or this will fail when riscof runs the coverage command |
cmuellner
added a commit
to cmuellner/riscv-arch-test
that referenced
this pull request
Nov 15, 2023
The {m,s,h}envcfg CSRs have been defined a long time ago.
They contain bits that are defined by a the following ISA extensions:
Zicbom_Zicboz_Zicsr_Ssdtso_Sstc
This patch introduces a test which attempts to write all of the defined bits
in menvcfg (similar to riscv-non-isa#381). After the tests, the original value of
the CSR will be restored to avoid side-effects with other tests.
Future commits could introduce the following additional tests:
* write tests for the bits in senvcfg
* write tests for the bits in henvcfg
* test that {m,s,h}envcfg CSRs are only accessible in the relevant modes
Signed-off-by: Christoph Müllner <[email protected]>
15 tasks
cmuellner
added a commit
to cmuellner/riscv-arch-test
that referenced
this pull request
Nov 17, 2023
The {m,s,h}envcfg CSRs have been defined a long time ago.
They contain bits that are defined by a the following ISA extensions:
Zicbom_Zicboz_Zicsr_Ssdtso_Sstc
This patch introduces a test which attempts to write all of the defined bits
in menvcfg (similar to riscv-non-isa#381). After the tests, the original value of
the CSR will be restored to avoid side-effects with other tests.
This commit is incomplete, as it does not test the illegal exceptions
which are triggered on access violations.
Signed-off-by: Christoph Müllner <[email protected]>
|
This PR is on halt since last 3,4 months. @dansmathers please update the test and add coverpoint definitions so that it can be merged. |
Signed-off-by: James Shi <[email protected]>
Signed-off-by: James Shi <[email protected]>
|
Sorry, removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mconfigptr is a read-only CSR defined in priv spec 1.12. The test attempts a read/write (illegal instruction exception expected)/read. The read data value is implementation dependent so the read data value is ignored.
Related Issues
Requires sail update for signatures to pass: riscv/sail-riscv#293
Ratified/Unratified Extensions
List Extensions
MCONFIGPTR exists in the priv spec 1.12 and used by the discovery task group.
Reference Model Used
Mandatory Checklist:
Optional Checklist: